Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos - Singer -> Signer #5714

Merged
merged 4 commits into from
Mar 6, 2025
Merged

Fix typos - Singer -> Signer #5714

merged 4 commits into from
Mar 6, 2025

Conversation

rhowe
Copy link
Contributor

@rhowe rhowe commented Nov 18, 2024

Motivation and Context

I spotted a couple of typos in method names which aren't part of the public API.

Modifications

Correct Singer to Signer.

Testing

git grep Singer returns 0 results

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@rhowe rhowe requested a review from a team as a code owner November 18, 2024 11:13
@dagnir dagnir enabled auto-merge December 20, 2024 23:14
@dagnir
Copy link
Contributor

dagnir commented Dec 20, 2024

LGTM! Thanks for the contribution.

auto-merge was automatically disabled January 30, 2025 23:07

Head branch was pushed to by a user without write access

@dagnir dagnir added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
@dagnir dagnir added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
@dagnir dagnir added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2025
@dagnir dagnir added this pull request to the merge queue Mar 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2025
@dagnir dagnir enabled auto-merge March 5, 2025 18:55
@dagnir dagnir added this pull request to the merge queue Mar 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 6, 2025
@dagnir dagnir added this pull request to the merge queue Mar 6, 2025
Merged via the queue into aws:master with commit 8997bb4 Mar 6, 2025
9 checks passed
@rhowe rhowe deleted the less-karaoke branch March 6, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants